Add datagrams.createWritable() #620
Open
+122
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Meeting:
|
jan-ivar
changed the title
jan-ivar
force-pushed
the
datagramswritable
branch
from
9e88485 to
db89b5f
Compare
|
This needs a bit more surgery to the algorithms. Will ping folks for review when that's done. |
|
It would be useful to add an Example to section 14 showing the use of datagrams.createWriteable(), perhaps juxtaposed against the default writeable, to show that both can be used simultaneously. |
nidhijaju
reviewed
Jan 29, 2025
| readonly attribute ReadableStream readable; | ||
| readonly attribute WritableStream writable; | ||
| readonly attribute WebTransportDatagramsWritable writable; |
There was a problem hiding this comment.
I think it's confusing to have both CreateWritable() and writable. If we call createWritable() two times and then access writable, do we get the WritableStream from the first createWritable() call or a third instance of a WritableStream?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #610.
Preview | Diff